Skip to content

Conversation

@pochmax
Copy link

@pochmax pochmax commented Jul 16, 2025

Hello,

I’m submitting this pull request because I’ve been blocked for a while on my project due to an issue that forces me to stay on Node 16.

I’m working on a Mac with an ARM64 architecture and we’re using LoopBack in our project.
To be able to use this package, we need a version of ibm_db higher than 3.x.x.
All tests have passed except the configuration one — I’ve modified as much data as possible to get most of the tests to pass (I haven’t pushed these changes).

Thank you in advance,

Have a great day,

Best regards,

Max Pochet.

Signed-off-by: Max Pochet <max.pochet-cic@ibm.com>
@pochmax pochmax requested a review from dhmlau as a code owner July 16, 2025 16:03
Copy link
Member

@dhmlau dhmlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pochmax, thanks for the PR. LGTM.

@dhmlau
Copy link
Member

dhmlau commented Jul 16, 2025

Since the CI is broken and the changes look reasonable to me, I'm going to merge this PR. Fixing the CI would involve similar fixes anyway.

@dhmlau dhmlau merged commit 6965347 into loopbackio:master Jul 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants