docs(typeorm): add info for registering connection #1382
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bhavyasf <37434313+bhavyasf@users.noreply.github.com>
Member
|
Hi @bhavyasf, thanks for the PR! Unfortunately LB4 docs are not edited here, but rather at https://github.com/loopbackio/loopback-next/tree/master/extensions/typeorm/README.md. In addition, there is also a TypeORM Connection Booter which means this manual registration should not be necessary: |
Member
|
closing this PR per the above comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried using
@loopback/typeormlocally and suddenly getting an error because connection was not coming Then I got an idea to register the connection somewhere inapplication.tswhich was also missing in the doc. Hence the PR.Signed-off-by: bhavyasf 37434313+bhavyasf@users.noreply.github.com