This repository was archived by the owner on Jan 26, 2022. It is now read-only.
Use Httplug as HTTP transport layer#93
Merged
mavimo merged 4 commits intoloopline-systems:developfrom Oct 15, 2018
Merged
Conversation
ste93cry
force-pushed
the
feature/httplug-client
branch
from
fedc4db to
3bd3fbb
Compare
ste93cry
force-pushed
the
feature/httplug-client
branch
8 times, most recently
from
40046cf to
2f9ce91
Compare
ste93cry
force-pushed
the
feature/httplug-client
branch
8 times, most recently
from
930c62c to
045008e
Compare
mavimo
suggested changes
Sep 27, 2018
Collaborator
mavimo
left a comment
mavimo
left a comment
There was a problem hiding this comment.
We have some issue on test, and we should include some more doc on hot to use this new feature.
I really like to externalise transport layer from lib but we should be sure that all user should be able to use it without issue.
ste93cry
force-pushed
the
feature/httplug-client
branch
2 times, most recently
from
bfe340b to
8df2dbc
Compare
ste93cry
force-pushed
the
feature/httplug-client
branch
from
8df2dbc to
c864ae9
Compare
mavimo
suggested changes
Oct 3, 2018
ste93cry
force-pushed
the
feature/httplug-client
branch
2 times, most recently
from
ede3b83 to
baef59d
Compare
ste93cry
force-pushed
the
feature/httplug-client
branch
from
baef59d to
6f7e376
Compare
mavimo
approved these changes
Oct 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR I've introduced the support for Httplug as transport layer. In this way we don't have to maintain our own implementation of an HTTP client (cURL in the simplest case) and we can offer more flexibility to users of this library leaving to them the choice of what they prefer to use to send HTTP requests (even Guzzle if they want).