Displaying result status in summary #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
narasimhan-v
force-pushed
the
results_summary_status
branch
from
46a1f5f to
236a0a2
Compare
harish-24
reviewed
Apr 27, 2020
avocado-setup.py
Outdated
| result_link += "/job.log\n" | ||
| with open(result_json, encoding = "utf-8") as fp: | ||
| result_state = json.load(fp) | ||
| for state in ['total', 'pass', 'cancel', 'errors', 'failures', 'skip']: |
Collaborator
There was a problem hiding this comment.
please add warn as well
Collaborator
Author
There was a problem hiding this comment.
@harish-24 WARN is not found in the json file. So I did not add it.
Collaborator
There was a problem hiding this comment.
@narasimhan-v I see a warn in there,
{
"cancel": 0,
"debuglog": "/home/satheesh/data/gits/github/avocado/job-2020-03-30T12.39-8a51c2c/job.log",
"errors": 0,
"failures": 0,
"interrupt": 0,
"job_id": "8a51c2c2ab2e400fc5089b3e6fd26244e383427e",
"pass": 1,
"skip": 0,
"tests": [
{
"end": 1585552154.4747539,
"fail_reason": null,
"id": "1-/bin/true",
"logdir": "/home/satheesh/data/gits/github/avocado/job-2020-03-30T12.39-8a51c2c/test-results/1-_bin_true",
"logfile": "/home/satheesh/data/gits/github/avocado/job-2020-03-30T12.39-8a51c2c/test-results/1-_bin_true/debug.log",
"start": 1585552154.219356,
"status": "PASS",
"time": 0.2553977966308594,
"whiteboard": ""
}
],
"time": 0.2553977966308594,
"total": 1,
"warn": 0
Collaborator
Author
There was a problem hiding this comment.
okay, let me recheck and add this. Thanks @harish-24 and @sathnaga
Collaborator
Author
There was a problem hiding this comment.
Seems I had older avocado in the system I tested.
Will add them.
commit c6b0c8180cd38b66d29729eb825bc0d4155a33c8
Author: Wainer dos Santos Moschetta <wainersm@redhat.com>
Date: Fri Jan 10 15:25:48 2020 -0300
plugins: jsonresult: add missing warn and interrupt fields
Collaborator
Author
There was a problem hiding this comment.
@harish-24 please check now. Added warn and interrupt
sathnaga
requested changes
Apr 28, 2020
avocado-setup.py
Outdated
| result_link += "/job.log\n" | ||
| with open(result_json, encoding = "utf-8") as fp: | ||
| result_state = json.load(fp) | ||
| for state in ['total', 'pass', 'cancel', 'errors', 'failures', 'skip']: |
Collaborator
There was a problem hiding this comment.
@narasimhan-v I see a warn in there,
{
"cancel": 0,
"debuglog": "/home/satheesh/data/gits/github/avocado/job-2020-03-30T12.39-8a51c2c/job.log",
"errors": 0,
"failures": 0,
"interrupt": 0,
"job_id": "8a51c2c2ab2e400fc5089b3e6fd26244e383427e",
"pass": 1,
"skip": 0,
"tests": [
{
"end": 1585552154.4747539,
"fail_reason": null,
"id": "1-/bin/true",
"logdir": "/home/satheesh/data/gits/github/avocado/job-2020-03-30T12.39-8a51c2c/test-results/1-_bin_true",
"logfile": "/home/satheesh/data/gits/github/avocado/job-2020-03-30T12.39-8a51c2c/test-results/1-_bin_true/debug.log",
"start": 1585552154.219356,
"status": "PASS",
"time": 0.2553977966308594,
"whiteboard": ""
}
],
"time": 0.2553977966308594,
"total": 1,
"warn": 0
sathnaga
reviewed
Apr 28, 2020
avocado-setup.py
Outdated
| with open(result_json, encoding = "utf-8") as fp: | ||
| result_state = json.load(fp) | ||
| for state in ['total', 'pass', 'cancel', 'errors', 'failures', 'skip']: | ||
| result_link += "| %s %s |" % (state, str(result_state[state])) |
Collaborator
There was a problem hiding this comment.
and better to add a try: except here inorder to handle a missing key in different avocado version if any...
When multiple tests are run, along with kernel messages output, it becomes difficult to read the status of the tests. This commits tries to solve that by displaying the status in the summary. Signed-off-by: Narasimhan V <sim@linux.vnet.ibm.com>
narasimhan-v
force-pushed
the
results_summary_status
branch
from
236a0a2 to
4711ef2
Compare
Previously we were having set length of spaces needed in the result summary. Now, we compute the length of items displayed in first column of summary, and use it to compute space needed. Signed-off-by: Narasimhan V <sim@linux.vnet.ibm.com>
Collaborator
Author
|
harish-24
approved these changes
Apr 28, 2020
sathnaga
approved these changes
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple tests are run, along with kernel messages output,
it becomes difficult to read the status of the tests. This commits
tries to solve that by displaying the status in the summary.
Signed-off-by: Narasimhan V sim@linux.vnet.ibm.com