Add UndoManager undo_count() and redo_count()#725
Merged
Conversation
Contributor
Author
|
This build failure seems unrelated to my change? |
Member
|
Yeah, I'm fixing that |
Member
|
Can you allow me to push to this branch @NSTroy |
Contributor
Author
Member
|
You can merge the main branch to fix the ci issue now |
- Surface the undo_stack and redo_stack depths - Add undo_count() and redo_count() checks to unit tests
zxch3n
pushed a commit
to synoet/loro
that referenced
this pull request
May 20, 2025
- Surface the undo_stack and redo_stack depths - Add undo_count() and redo_count() checks to unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
undo_stackandredo_stackdepthsundo_count()andredo_count()checks to unit testsThis helps us use Loro's UndoManager as an alternative implementation of Cocoa Foundation's UndoManager API, which is obliged to be able to return an
undoCountandredoCount.