Fix review follow-ups for Rust APIs and benches#935
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c3fb676b97
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
crates/kv-store/src/block.rs
Outdated
| } | ||
|
|
||
| pub fn decode( | ||
| pub(crate) fn decode_verified( |
There was a problem hiding this comment.
Keep
Block::decode public for downstream callers
loro-kv-store still exposes crates/kv-store/src/lib.rs's pub mod block, so turning Block::decode into the crate-private decode_verified is a semver-breaking API regression for external crates that currently decode already-validated blocks themselves. The workspace still compiles because every in-tree caller is internal, but any downstream Block::decode(...) call will stop compiling after this patch.
Useful? React with 👍 / 👎.
Summary
Noneinstead of panicking inget_editor_at_unicode_pos, and add a regression testkv-storelazy decode path explicit and remove the extra re-boxing in diff calculatorsVerification