fix: exclude wasi from js-specific build deps#986
Merged
Conversation
chore: include changeset idk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
loro-internaldoesn't compile to WASI due to JS-specific timestamp bindings (usingDate), along with a JS feature forgetrandom. In my case, it prevents my Loro-based project from running via WASI/WIT.Seems like a similar issue has come up before for Emscripten in #966. This PR does the same fix as for Emscripten, relying on native/WASI capabilities instead. This also fixes the build-side of the existing #881.
First time contributing to this project, so LMK if more tests should be run. I've done the testing below (heavily inspired by #966).
Compile / target checks
cargo check -p loro-internalcargo check -p loro-internal --target wasm32-unknown-emscriptencargo check -p loro --target wasm32-unknown-emscriptencargo check -p loro-internal --target wasm32-wasip1cargo check -p loro --target wasm32-wasip1cargo check -p loro --target wasm32-wasip2cargo check -p loro-internal --target wasm32-unknown-unknowncargo check -p loro-internal --target wasm32-wasip2Dependency isolation
cargo tree -p loro --target wasm32-unknown-emscripten -e normal -i wasm-bindgen, no wasm-bindgencargo tree -p loro-internal --target wasm32-wasip1 -e normal -i wasm-bindgen, no wasm-bindgencargo tree -p loro-internal --target wasm32-unknown-unknown -e normal -i wasm-bindgen, has wasm-bindgen presentBrowser WASM package pipeline (from
crates/loro-wasm)pnpm exec deno run -A ./scripts/build.ts releasepnpm exec rollup -cpnpm exec deno run -A ./scripts/post-rollup.tsnode --expose-gc ./node_modules/vitest/vitest.mjs runpnpm exec tsc --noEmitdeno test -Afromcrates/loro-wasm/deno_testsTimestamp smoke tests
crates/loro-wasm/nodejs/index.jscrates/loro-wasm/web/index.js