chore: migrate templates from .tile shim to Bulma 1.x .columns#80
Merged
Conversation
Closes #66 ## What Replace the deprecated `.tile` markup in _layouts/default.html, _layouts/aggregate_default.html, _layouts/author_default.html, and _includes/authors.html with Bulma 1.x `.columns` / `.column`. The outer `tile is-ancestor is-vertical` wrapper becomes a plain block container; the `tile is-parent` row becomes `<div class="columns">`; the 8/4 children become `<div class="column is-8 main">` and `<div class="column is-4">`; the `tile is-parent is-vertical sidebar` becomes a plain `<div class="sidebar">`; and the `tile is-child widget` widget wrappers become plain `<div class="widget">`. Delete the 46-line tile-system shim block from assets/css/custom.css. ## Why PR #65 vendored Bulma 1.0.4, which removed the `.tile` layout primitives entirely. To preserve the existing layouts without rewriting templates in that PR, a temporary CSS shim was added to custom.css. This commit completes the migration so templates use Bulma's actual grid, and the shim block is no longer needed in the repo. ## Notes - The `.tile.is-ancestor.is-vertical` outer wrapper had a single purpose: vertically stacking the nav above the content row. `<div>` elements stack by default in normal flow, so the wrapper has been removed entirely rather than translated to `.columns.is-vertical` — that exists but adds complexity for no reason. - `.sidebar` and `.widget` are kept as plain div selectors so existing CSS hooks (e.g. `.sidebar { padding: 0 0.75rem 0.75rem 0.75rem !important; }` in custom.css) continue to apply unchanged. - Bulma's `.columns` collapses to a single column at mobile widths (< 769px) and goes side-by-side at tablet+, matching the tile system's responsive behavior exactly. No additional `is-mobile` / `is-desktop` modifiers needed. - _layouts/aggregate_default.html and _layouts/author_default.html still inline their own nav copy rather than using _includes/nav.html. This pre-existing duplication is unchanged. Signed-off-by: jmeridth <jmeridth@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #66
What
Replace the deprecated `.tile` markup in `_layouts/default.html`, `_layouts/aggregate_default.html`, `_layouts/author_default.html`, and `_includes/authors.html` with Bulma 1.x `.columns` / `.column`. The outer `tile is-ancestor is-vertical` wrapper becomes a plain block container; the `tile is-parent` row becomes `
Why
PR #65 vendored Bulma 1.0.4, which removed the `.tile` layout primitives entirely. To preserve the existing layouts without rewriting templates in that PR, a temporary CSS shim was added to `custom.css`. This PR completes the migration so templates use Bulma's actual grid, and the shim block is no longer needed in the repo.
Notes
Testing
Verified locally with cache wiped (`rm -rf _site .jekyll-cache`) and `bundle exec jekyll serve --livereload --future`: