Conversation
当后端可用时，WebDAVService 通过 POST /api/proxy/webdav 代理请求， 避免浏览器直接跨域访问 WebDAV 服务器。后端不可用时回退到浏览器直连。
📝 WalkthroughWalkthroughWebDAVService is extended with optional backend proxy routing to bypass browser CORS constraints. A ChangesWebDAV Proxy Support
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/services/webdavService.ts (1)
174-199:⚠️ Potential issue | 🟠 Major | ⚡ Quick winKeep the timeout active for the fallback
PROPFIND.The 10s timer only covers the initial
HEAD. IfHEADreturns non-OK and the server stalls onPROPFIND, this path can hang indefinitely.Suggested fix
- const controller = new AbortController(); - const timeoutId = setTimeout(() => controller.abort(), 10000); + const controller = new AbortController(); + const timeoutId = setTimeout(() => controller.abort(), 10000); try { const headResponse = await fetch(dirUrl, { method: 'HEAD', headers: { 'Authorization': this.getAuthHeader(), }, signal: controller.signal, }); - clearTimeout(timeoutId); - if (headResponse.ok) return true; const propfindResponse = await fetch(dirUrl, { method: 'PROPFIND', headers: { 'Authorization': this.getAuthHeader(), 'Depth': '0', }, + signal: controller.signal, }); return propfindResponse.ok || propfindResponse.status === 207; } catch (fetchError: unknown) { - clearTimeout(timeoutId); - if ((fetchError as Error).name === 'AbortError') { throw new Error('连接超时。请检查WebDAV服务器是否可访问。'); } throw fetchError; + } finally { + clearTimeout(timeoutId); }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/services/webdavService.ts` around lines 174 - 199, The current timeout only wraps the initial HEAD request (using controller and timeoutId) but is not passed to the fallback PROPFIND, so PROPFIND can hang; fix by ensuring the PROPFIND request also uses an AbortController with the same timeout semantics — either reuse the existing controller and keep the timeout active until after both responses (clearTimeout only after PROPFIND completes) or create a new AbortController/timeout for the PROPFIND; update the fetch call that assigns propfindResponse to include signal: controller.signal (or the new controller) and ensure clearTimeout(timeoutId) is called after the final request completes.
🧹 Nitpick comments (1)
src/services/webdavService.ts (1)
619-626: ⚡ Quick winRoute
OPTIONSthrough the proxy too.This is still a browser-side WebDAV request, so the same CORS setup this PR is fixing will make
getServerInfo()return{}even when the proxied operations succeed.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/services/webdavService.ts` around lines 619 - 626, getServerInfo() currently calls fetch(this.config.url) with method 'OPTIONS' which bypasses the proxy and will fail CORS; change getServerInfo to use the same proxy routing as the other WebDAV methods (i.e., send the OPTIONS request to the proxy endpoint instead of this.config.url and include the original target URL/credentials the proxy expects — follow the same pattern used elsewhere in this file for proxied requests) so the OPTIONS call is routed through the proxy and CORS is avoided.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/services/webdavService.ts`:
- Around line 20-26: Create a centralized "proxy then direct" helper to match
testConnection()'s fallback behavior: update proxyFetch to either call a new
helper (e.g., proxyThenDirect) or implement try/catch around backend.proxyWebDAV
calls so uploadFile, downloadFile, fileExists, and listFiles no longer await
proxyFetch directly without handling failures; instead have those methods call
the helper which first attempts backend.proxyWebDAV(this.config.id, ...) and on
any thrown error falls back to the existing direct-browser paths used in this
class (the same direct handlers testConnection() uses), ensuring the helper
returns the Response or result to the calling methods and preserves signature
compatibility with proxyFetch.
---
Outside diff comments:
In `@src/services/webdavService.ts`:
- Around line 174-199: The current timeout only wraps the initial HEAD request
(using controller and timeoutId) but is not passed to the fallback PROPFIND, so
PROPFIND can hang; fix by ensuring the PROPFIND request also uses an
AbortController with the same timeout semantics — either reuse the existing
controller and keep the timeout active until after both responses (clearTimeout
only after PROPFIND completes) or create a new AbortController/timeout for the
PROPFIND; update the fetch call that assigns propfindResponse to include signal:
controller.signal (or the new controller) and ensure clearTimeout(timeoutId) is
called after the final request completes.
---
Nitpick comments:
In `@src/services/webdavService.ts`:
- Around line 619-626: getServerInfo() currently calls fetch(this.config.url)
with method 'OPTIONS' which bypasses the proxy and will fail CORS; change
getServerInfo to use the same proxy routing as the other WebDAV methods (i.e.,
send the OPTIONS request to the proxy endpoint instead of this.config.url and
include the original target URL/credentials the proxy expects — follow the same
pattern used elsewhere in this file for proxied requests) so the OPTIONS call is
routed through the proxy and CORS is avoided.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: e2663214-13af-4e78-ba05-61c36e2124e6
📒 Files selected for processing (1)
src/services/webdavService.ts
Comment on lines
+20
to
+26
| private async proxyFetch( | ||
| method: string, | ||
| fullPath: string, | ||
| body?: string, | ||
| headers?: Record<string, string>, | ||
| ): Promise<Response> { | ||
| return backend.proxyWebDAV(this.config.id, method, fullPath, body, headers); |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
backend_file="$(fd -i '^backendAdapter\.ts$' src/services . | head -n 1)"
if [ -z "${backend_file:-}" ]; then
echo "backendAdapter.ts not found" >&2
exit 1
fi
echo "=== backend adapter: $backend_file ==="
sed -n '1,260p' "$backend_file"
echo
echo "=== proxyWebDAV / isAvailable references ==="
rg -n -C3 '\bproxyWebDAV\b|\bisAvailable\b' "$backend_file" src/services/webdavService.tsRepository: lostiv/GithubStarsManager
Length of output: 11228
🏁 Script executed:
wc -l src/services/webdavService.tsRepository: lostiv/GithubStarsManager
Length of output: 103
🏁 Script executed:
cat -n src/services/webdavService.tsRepository: lostiv/GithubStarsManager
Length of output: 24021
Inconsistent proxy failure handling — only testConnection() falls back to direct access.
The proxy branches in uploadFile() (lines 237–254), downloadFile() (lines 363–376), fileExists() (lines 430–433), and listFiles() (lines 456–478) all await proxyFetch() directly without try-catch fallback. In contrast, testConnection() wraps its proxy calls in a try-catch that falls back to direct browser access. When backend.proxyWebDAV() fails transiently, these methods throw immediately, even though the direct path exists in the class and would likely succeed.
backend.proxyWebDAV() does not flip backend.isAvailable on failure—it only checks the initial state. Centralize a proxy-then-direct helper pattern here to match testConnection()'s approach.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/services/webdavService.ts` around lines 20 - 26, Create a centralized
"proxy then direct" helper to match testConnection()'s fallback behavior: update
proxyFetch to either call a new helper (e.g., proxyThenDirect) or implement
try/catch around backend.proxyWebDAV calls so uploadFile, downloadFile,
fileExists, and listFiles no longer await proxyFetch directly without handling
failures; instead have those methods call the helper which first attempts
backend.proxyWebDAV(this.config.id, ...) and on any thrown error falls back to
the existing direct-browser paths used in this class (the same direct handlers
testConnection() uses), ensuring the helper returns the Response or result to
the calling methods and preserves signature compatibility with proxyFetch.
This was referenced May 12, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
当后端可用时，WebDAVService 通过 POST /api/proxy/webdav 代理请求， 避免浏览器直接跨域访问 WebDAV 服务器。后端不可用时回退到浏览器直连。
Summary by CodeRabbit
New Features
Improvements