Skip to content

Fix placeholder issue in PUT /api/releases for successful insertion#6

Merged
lostiv merged 1 commit into
mainfrom
fix/sync
May 11, 2026
Merged

Fix placeholder issue in PUT /api/releases for successful insertion#6
lostiv merged 1 commit into
mainfrom
fix/sync

Conversation

@lostiv
Copy link
Copy Markdown
Owner

@lostiv lostiv commented May 11, 2026

fix: 修复 PUT /api/releases 缺少一个占位符导致插入失败

VALUES 子句只有 14 个 ?,但表有 15 列,补全为 15 个

Summary by CodeRabbit

  • Bug Fixes
    • Fixed SQL formatting in the releases bulk upsert endpoint to ensure proper query execution.

Review Change Stack

@
fix: 修复 PUT /api/releases 缺少一个占位符导致插入失败

VALUES 子句只有 14 个 ?,但表有 15 列,补全为 15 个
@
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 11, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 05d9ca0c-9761-47af-8292-a09218e98ab9

📥 Commits

Reviewing files that changed from the base of the PR and between 59ea945 and 839af40.

📒 Files selected for processing (1)
  • server/src/routes/releases.ts

📝 Walkthrough

Walkthrough

The PUT /api/releases bulk upsert SQL prepared statement is adjusted to reformat the column list template within the INSERT OR REPLACE INTO releases clause, specifically in the zipball_url, tarball_url portion immediately preceding the VALUES clause.

Changes

Releases SQL Formatting

Layer / File(s) Summary
SQL Upsert Statement
server/src/routes/releases.ts
The prepared SQL template for bulk upserting releases records is reformatted to adjust the column list template text.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A rabbit hops through SQL land,
Where columns stand in neat array—
A formatting fix, both small and grand,
Makes queries dance the proper way! 🐰✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main fix: addressing a placeholder issue in the PUT /api/releases endpoint SQL statement that was preventing successful insertions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/sync

Comment @coderabbitai help to get the list of available commands and usage tips.

@lostiv lostiv merged commit a036fad into main May 11, 2026
1 check passed
@lostiv lostiv deleted the fix/sync branch May 11, 2026 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant