Fix User and HMI files in ARSim cmd line interface #1
Merged
Conversation
when in debug. This will help debug issues with these values.
These were not being used unless user files was specified
This will default to None which is not an empty string which this code assumes
sclaiborne
changed the title
AndrewMusser
approved these changes
Nov 28, 2023
Contributor
AndrewMusser
left a comment
AndrewMusser
left a comment
There was a problem hiding this comment.
These look good to me.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes some bugs with user and hmi files
Why
These break builds in the following cases: