Добавлена обработка исключения ValueError в muted_until_datetime#69
Merged
love-apples merged 1 commit intolove-apples:mainfrom Mar 25, 2026
Merged
Conversation
…e и добавлены тесты для проверки корректности возвращаемого значения.
Olegt0rr
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Исправление падения при доступе к DialogMuted.muted_until_datetime, когда диалог замьючен “навсегда” и API присылает экстремально большое значение временной метки (INT64_MAX), из-за чего datetime.fromtimestamp() выбрасывает ValueError.
Changes:
- Добавлен перехват
ValueErrorвDialogMuted.muted_until_datetimeс возвратомdatetime.max. - Добавлены unit-тесты на поведение для “навсегда” (INT64_MAX) и для обычной временной метки.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
maxapi/types/updates/dialog_muted.py |
Обработка ValueError при конвертации muted_until в datetime для случая “навсегда”. |
tests/test_types.py |
Тесты, фиксирующие ожидаемое поведение muted_until_datetime для INT64_MAX и нормального timestamp. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #65