Исправлено обновление при удалении диалога#71
Merged
love-apples merged 2 commits intolove-apples:mainfrom Mar 25, 2026
Merged
Conversation
Olegt0rr
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
PR исправляет ошибку при обработке события удаления диалога (dialog_removed), из‑за которой библиотека пыталась запросить уже удалённый чат и падала с 404, что ломало доставку события до обработчиков.
Changes:
- В
enrich_eventдобавлена ветка дляDialogRemoved, чтобы не вызыватьget_chat_by_idдля удалённого диалога. DialogRemovedдобавлен в публичные экспортыmaxapi.types.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| maxapi/utils/updates.py | Предотвращает авто-запрос чата для DialogRemoved при обогащении события. |
| maxapi/types/init.py | Экспортирует DialogRemoved через __all__ для публичного API. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #70