fix(word): calculate_branching_entropy max() 빈 시퀀스 방어 가드 추가#311
Merged
lovit merged 1 commit intorefactor-2026from Mar 10, 2026
Merged
fix(word): calculate_branching_entropy max() 빈 시퀀스 방어 가드 추가#311lovit merged 1 commit intorefactor-2026from
lovit merged 1 commit intorefactor-2026from
Conversation
L 또는 R 빈도 맵이 비어 있을 경우 max() 호출 시 ValueError가 발생할 수 있어 max(iterable, default=0) 패턴으로 수정 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
calculate_branching_entropy_accessor_variety_batch함수에서L또는R이 비어 있을 때max(l_groupby_len)호출로ValueError발생 가능.max(l_groupby_len, default=0)패턴으로 수정해 빈 입력 시 안전하게 동작하도록 개선.관련 이슈
Close #308
Test plan
uv run pyright soynlp/word/— 0 errorsuv run pytest tests/unit/test_wordextractor.py— 19 passed