Fix Issue #35: hoist Config Struct to constant to avoid per-call allocation#36
Open
obsidiannnn wants to merge 1 commit intolow-rb:mainfrom
Open
Fix Issue #35: hoist Config Struct to constant to avoid per-call allocation#36obsidiannnn wants to merge 1 commit intolow-rb:mainfrom
obsidiannnn wants to merge 1 commit intolow-rb:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #35
Change
Hoisted
Struct.newout of theconfigmethod body into a constantso the anonymous Struct class is allocated once at load time rather
than on every call to
LowType.config.Before
Every
LowType.configcall allocated and discarded a new Struct class.After
Struct class is created once.
@config ||=memoizes the instance as before.