Skip to content

Conversation

@GregAC
Copy link
Contributor

@GregAC GregAC commented Sep 30, 2022

I had a go at adding interrupts to the single step test. I ran into various failures but I suspect I'm chasing the same bugs as @ctopal and @hcallahan-lowrisc are in #1765 so I won't continue that work until #1765 is resolved.

@GregAC
Copy link
Contributor Author

GregAC commented Sep 30, 2022

It's a little concerning we hadn't yet realised that we had a bug where mstatus.mie effects interrupts seen in U mode (that field should be ignored when in U mode, only the per interrupt enable bits should be relevant). Still it's not the most critical bug, I've created a separate issue to track the extra testing/coverage we need to test that and other possible behaviours with different states of mstatus that we may also be missing #1825

@GregAC GregAC requested a review from vogelpi October 13, 2022 13:56
@GregAC
Copy link
Contributor Author

GregAC commented Oct 13, 2022

@ctopal @hcallahan-lowrisc @vogelpi PTAL

Copy link
Contributor

@vogelpi vogelpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @GregAC !

@GregAC GregAC merged commit 48733e2 into lowRISC:master Oct 13, 2022
@GregAC GregAC deleted the irq_fixes branch October 13, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants