[doc] Fix documented mstatus reset value #2056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcallahan-lowrisc
approved these changes
Jul 3, 2023
rswarbrick
approved these changes
Jul 4, 2023
Contributor
rswarbrick
left a comment
rswarbrick
left a comment
There was a problem hiding this comment.
Minor tidiness question, but this looks sensible otherwise!
| mv x30, x1 | ||
| mv x31, x1 | ||
|
|
||
| csrr x1, mstatus |
Contributor
There was a problem hiding this comment.
No big deal, but could you write something in the commit message that explains why this change is in this commit?
Contributor
Author
There was a problem hiding this comment.
Ah it shouldn't be in this commit! This was my quick hack to double check the reset value, must have got swept in accidentally.
Probably explains the CI fail too, seems spike and Ibex disagree on the PoR values. Something to fix but not for this PR if ditching this line fixes the CI problem.
CI breakages are observed with v2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2054