[meson] Fix GCC ld cross-configuration #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sam Elliott <selliott@lowrisc.org>
Contributor
Author
|
Performed both a clang build and a gcc build using the resulting combined toolchain, both succeeded on |
Collaborator
|
I guess this is good for merging? If it works that way... |
Collaborator
|
Oh well, too late by 2 minutes :-) |
Contributor
Author
|
Sorry :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't quite know what's going on here, meson should raise an error with a good explanation if it tries to set the gnu linker to anything that isn't the exact string
bfd,goldorlldand yet it just… doesn't? Instead you get "unable to find dynamic linker" with no useful error message, and a useless log.Anyway, turns out I got #26 wrong. Selecting a linker is required for clang, but not for the gnu toolchain (because the gnu toolchain is built as one piece, not as a cross-compiler). So this change removes these lines in the gcc meson configuration.
I tested this by trying the
HEADbuild from 15 minutes ago, and then discovering that meson was totally hosed. Applying this fix sorts it out, once I debugged how meson was trying to find the linker version.