Skip to content

Conversation

AlexJones0
Copy link

@AlexJones0 AlexJones0 commented Jan 16, 2025

@rivos-eblot this needs cherry-picking to ot-darjeeling-9.1.0 to fix CI failures there as well.

This is failing for a bit today because of brown-out due to incoming deprecation.

@AlexJones0 AlexJones0 changed the title .github: Bump action-checkout to v4 in CI to solve deprecation errors .github: Bump upload-artifact to v4 in CI to solve deprecation errors Jan 16, 2025
@rivos-eblot
Copy link

rivos-eblot commented Jan 16, 2025

Could you take the opportunity of updating this file to add a version to the pylint dependency (that would be 3.3.3) @ line 91?
I've fixed this on our own gitlab CI, as I think we need to version Python package to have reproducible builds. Thanks.

…tion errors

Also fix the `pylint` version used to 3.3.3 for reproducible builds.

Signed-off-by: Alex Jones <alex.jones@lowrisc.org>
@AlexJones0 AlexJones0 changed the title .github: Bump upload-artifact to v4 in CI to solve deprecation errors .github: Bump artifact actions to v4 in CI to solve deprecation errors Jan 16, 2025
Copy link

@rivos-eblot rivos-eblot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@jwnrt jwnrt merged commit 812b743 into lowRISC:dev/ot-earlgrey-1.0.0-updates Jan 16, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants