[ot] scripts/opentitan: pyot.py: rework embedded flash management #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rivos-eblot
changed the title
loiclefort
reviewed
Jan 28, 2025
…bus index. Embedded flash option enables flash image generation for the internal flash controller. It now requires a bus index to specify to which QEMU bus the internal flash controller is connected, as this may depends on the machine configuration. Also assign an id to each drive option to avoid collisions due to QEMU assigning the same default id if not explicitly specified. Signed-off-by: Emmanuel Blot <eblot@rivosinc.com>
Signed-off-by: Emmanuel Blot <eblot@rivosinc.com>
rivos-eblot
force-pushed
the
dev/ebl/pyot_eflash
branch
from
2e1a28a to
4cc51b9
Compare
loiclefort
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous versions of QEMU OT were not capable of dealing with multiple SPI host buses + internal flash.
Rework
pyot.pyembedded flash management so that it is required to specify which MTD bus should be used when generating eflash image from ELF files.Also addresses a long lasting issue where per-test
icountvalue was not emitted in thepyot.py(CSV) reports.