Skip to content

Conversation

loiclefort
Copy link

REV register was removed from entropy_src in OpenTitan commit e7675d760235cbcfa327be948196b6418d10ff54.

REV register was removed from entropy_src in OpenTitan commit
e7675d760235cbcfa327be948196b6418d10ff54.

Signed-off-by: Loïc Lefort <loic@rivosinc.com>
Copy link

@AlexJones0 AlexJones0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this LGTM. Unfortunately, the register will be present in earlgrey_1.0.0.

I have an upcoming PR to switch the Earlgrey definition on ot-earlgrey-9.2.0 to emulate Earlgrey 1.0.0, so I'll rebase on top of this change and probably separate the entropy source into an ot_entropy_src_eg and ot_entropy_src_dj

@AlexJones0 AlexJones0 self-requested a review August 26, 2025 13:08
Copy link

@AlexJones0 AlexJones0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I didn't realise that Darjeeling didn't have an entropy_src.

I think in that case given the intention to move to emulating earlgrey_1.0.0, it may not make sense to make this change to then immediately revert it?

@AlexJones0 AlexJones0 self-requested a review August 26, 2025 13:10
@loiclefort
Copy link
Author

Actually, I didn't realise that Darjeeling didn't have an entropy_src.

The "old" darjeeling from the initial opentitan-integrated work did not have an entropy_src but is was added back.

@AlexJones0
Copy link

AlexJones0 commented Aug 26, 2025

The "old" darjeeling from the initial opentitan-integrated work did not have an entropy_src but is was added back.

Ah, I see. I didn't realize that this was recently changed. Sorry for the confusion.

In that case, yes, I think it is best to merge this and then separate EG 1.0.0 and DJ definitions in my follow-up PR.

@loiclefort loiclefort merged commit 2fd7075 into lowRISC:ot-earlgrey-9.2.0 Aug 26, 2025
7 checks passed
@loiclefort loiclefort deleted the fix-earlgrey-entropy_src branch September 25, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants