-
Notifications
You must be signed in to change notification settings - Fork 11
Python tools improvements #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emmanuel Blot <eblot@rivosinc.com>
AlexJones0
approved these changes
Sep 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks. I've left a couple of minor comments/suggestions.
0ff2263
to
c3fdecb
Compare
Using an existing Python module name is a very bad idea as it ends up conflicting when Python interpreter looks up for modules. Signed-off-by: Emmanuel Blot <eblot@rivosinc.com>
…ype hinting Signed-off-by: Emmanuel Blot <eblot@rivosinc.com>
… directory Signed-off-by: Emmanuel Blot <eblot@rivosinc.com>
Signed-off-by: Emmanuel Blot <eblot@rivosinc.com>
Signed-off-by: Emmanuel Blot <eblot@rivosinc.com>
… failure Signed-off-by: Emmanuel Blot <eblot@rivosinc.com>
QEMU executer should use QEMU wrapper. Signed-off-by: Emmanuel Blot <eblot@rivosinc.com>
Some fail test may report no execution time. Signed-off-by: Emmanuel Blot <eblot@rivosinc.com>
c3fdecb
to
d72f1a7
Compare
AlexJones0
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.