ot_vmapper: fix setting destination address when splitting ranges
#211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tting ranges When a smaller block of higher priority is carved out from bigger one (case a2), destination address was set as: right->dest = right->dest + right->start - VMAP_RANGE(current)->start; While start offset was calculated correctly, destination base was always intialized as zeros due to right->dest being 0, as it wasn't touched before getting allocated via g_new0(). Current block destination address should be used as the base here. Signed-off-by: Lech Perczak <lperczak@rivosinc.com>
rivos-eblot
changed the title
vmapper: fix setting destination address when splitting rangesot_vmapper: fix setting destination address when splitting ranges
AlexJones0
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a smaller block of higher priority is carved out from bigger one (case a2), destination address was set as:
While start offset was calculated correctly, destination base was always intialized as zeros due to right->dest being 0, as it wasn't touched before getting allocated via g_new0().
Current block destination address should be used as the base here.