tools: fix Git subprocess error handling
#227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subprocess.check_output may raise a SubprocessError, which is not a subclass of OSError. For example, when a git repository exists but no tag has been defined, git "describe" command exits with an error, which is translated into a (subclass of) SubprocessError exception by the subprocess module. Handle any SubprocessError exception. Signed-off-by: Emmanuel Blot <eblot@rivosinc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
subprocess.check_outputmay raise aSubprocessError, which is not a subclass ofOSError.For example, when a git repository exists but no tag has been defined, git "describe" command exits with an error, which is translated into a (subclass of)
SubprocessErrorexception by the subprocess module.Handle any
SubprocessErrorexception.