ot_i2c: Use matched address for ACQ start condition byte, not target address
#229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziuziakowska
force-pushed
the
ot_i2c_address_masking_fix
branch
from
3d13665 to
ed65676
Compare
rivos-eblot
reviewed
Oct 10, 2025
ziuziakowska
force-pushed
the
ot_i2c_address_masking_fix
branch
from
ed65676 to
803fa9d
Compare
This is a bugfix for target mode address masking. Previously, the OT I2C's bus address would be used for the address byte on a start condition. Now that address masking is implemented, the address that matched may not be exactly the bus address (as some bits are ignored). Hardware presents the matched address in the start condition byte so that software can perform different actions based on different target transaction addresses. Signed-off-by: Alice Ziuziakowska <a.ziuziakowska@lowrisc.org>
ziuziakowska
force-pushed
the
ot_i2c_address_masking_fix
branch
from
803fa9d to
0fbd27a
Compare
AlexJones0
approved these changes
Oct 13, 2025
jwnrt
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bugfix for target mode address masking.
Previously, the OT I2C's bus address would be used for the address byte on a start condition. Now that address masking is implemented, the address that matched may not be exactly the bus address (as some bits are ignored). Hardware presents the matched address in the start condition byte so that software can perform different actions based on different target transaction addresses.