hw/core: loader.c: make generic loader image loadable at will
#232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: I think it could also apply to EarlGrey since it has recently adopted the new reset sequence from Darjeeling, but I'm not sure how to test it. |
AlexJones0
approved these changes
Oct 13, 2025
include/hw/loader.h
Outdated
| RomGap rom_find_largest_gap_between(hwaddr base, size_t size); | ||
|
|
||
| void rom_load(void); | ||
| /* Load all registered ROMs */ |
There was a problem hiding this comment.
Probably this comment should be before the signature (and maybe also in the same style as above functions)?
Image file loaded with "-device loader,file=..." are copied back to their destination device when the generic QEMU reset feature is invoked. As OpenTitan device use a specialized reset scheme, we may need to copy the so-called "ROM" images (as QEMU non-modifiable image, not related to OT ROM controller images) at will. Add a public API to trigger this image-to-device copy since the default API is private. Signed-off-by: Emmanuel Blot <eblot@rivosinc.com>
rivos-eblot
force-pushed
the
dev/ebl/loadable_img
branch
from
e0a8f54 to
a9c4de8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Image file loaded with
-device loader,file=...are copied back to their destination device when the generic QEMU reset feature is invoked.As OpenTitan device use a specialized reset scheme, we may need to copy the so-called "ROM" images (as QEMU non-modifiable image, not related to OT ROM controller images) at will.
Add a public API to trigger this image-to-device copy since the default API is private.