Skip to content

Conversation

@pamaury
Copy link

@pamaury pamaury commented Oct 21, 2025

This step succeeds even when the script changes the code!

@pamaury pamaury requested review from jwnrt and rivos-eblot October 21, 2025 15:17
@pamaury pamaury force-pushed the fix_ci_format branch 2 times, most recently from 29b7529 to 30f3a80 Compare October 21, 2025 15:26
@pamaury pamaury requested a review from AlexJones0 October 21, 2025 15:28
Copy link

@AlexJones0 AlexJones0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the CI fix.

@rivos-eblot
Copy link

Note: could you apply the same update to the gitlab version so both CIs use the same rule? Thanks.

@pamaury
Copy link
Author

pamaury commented Oct 22, 2025

Note: could you apply the same update to the gitlab version so both CIs use the same rule? Thanks.

Sure, done, I don't have a way to test it but that should be a relatively safe change?

@rivos-eblot
Copy link

rivos-eblot commented Oct 22, 2025

Note: could you apply the same update to the gitlab version so both CIs use the same rule? Thanks.

Sure, done, I don't have a way to test it but that should be a relatively safe change?

Thanks. Yes, should be ok.

Signed-off-by: Amaury Pouly <amaury.pouly@lowrisc.org>
Signed-off-by: Amaury Pouly <amaury.pouly@lowrisc.org>
Signed-off-by: Amaury Pouly <amaury.pouly@lowrisc.org>
@pamaury
Copy link
Author

pamaury commented Oct 22, 2025

CI failures are unrelated to the PR

@pamaury pamaury merged commit 81955d4 into lowRISC:ot-9.2.0 Oct 22, 2025
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants