tools: romtool.py: fix a bug with VMEM file parsing and add Digest report option.
#262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
input stream is a binary string, not a text string. RE should match bytes, not string. Signed-off-by: Emmanuel Blot <eblot@rivosinc.com>
…M digest Signed-off-by: Emmanuel Blot <eblot@rivosinc.com>
AlexJones0
approved these changes
Oct 28, 2025
|
(it looks like a couple of the ownership ROM_EXT tests are flaky - I thought they might be, because the Github runner is slower and running them in parallel. I think generally it is fine to ignore the fails for now, especially for PRs like this where it is clearly not changing anything relevant). |
Author
Thanks for letting me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.