-
Notifications
You must be signed in to change notification settings - Fork 13
ot_spi_device: Implement HW registers for TPM mode
#283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b63021f to
0a76baf
Compare
5096f90 to
4083d71
Compare
| unsigned addr; | ||
| uint32_t offset; | ||
| unsigned nbytes; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any particular reason for the mix of uint32_t and unsigned?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following Emmanuel's advise.
4083d71 to
286c7b3
Compare
ot_spi_device: Implement hw registers for tpm mode
286c7b3 to
dfb9110
Compare
AlexJones0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this LGTM.
ziuziakowska
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some minor nits.
a9f3886 to
8e1785a
Compare
|
nit: may be capitalize HW & TPM in PR title? |
ot_spi_device: Implement hw registers for tpm modeot_spi_device: Implement HW registers for TPM mode
8e1785a to
aa026a5
Compare
aa026a5 to
64db210
Compare
Signed-off-by: Douglas Reis <doreis@lowrisc.org>
64db210 to
56ad091
Compare
|
The CI failures are related to USB, so I'll merge this PR. |
Implement the hw handled registers
To test use the Opentitan PR lowRISC/opentitan#28697 and run:
Fix: lowRISC/opentitan#27930