-
Notifications
You must be signed in to change notification settings - Fork 13
Add flake8 lint CI Job
#286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7012706 to
30422b1
Compare
flake8 lint CI stepflake8 lint CI Job
30422b1 to
fdc86bd
Compare
Signed-off-by: Alice Ziuziakowska <a.ziuziakowska@lowrisc.org>
Signed-off-by: Alice Ziuziakowska <a.ziuziakowska@lowrisc.org>
Signed-off-by: Alice Ziuziakowska <a.ziuziakowska@lowrisc.org>
fdc86bd to
f467678
Compare
rivos-eblot
requested changes
Nov 12, 2025
8bc07d4 to
a91eddd
Compare
jwnrt
approved these changes
Nov 12, 2025
jwnrt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though I agree with @rivos-eblot about removing that install flake8 from the YAML file
b89f211 to
5f7e70f
Compare
jwnrt
approved these changes
Nov 17, 2025
632ce9a to
dd97f88
Compare
Also renames the `lint-python` job to `lint-pylint` as there are two Python CI jobs now Signed-off-by: Alice Ziuziakowska <a.ziuziakowska@lowrisc.org>
dd97f88 to
be46898
Compare
…ke8` step Signed-off-by: Alice Ziuziakowska <a.ziuziakowska@lowrisc.org>
be46898 to
025af63
Compare
rivos-eblot
approved these changes
Nov 17, 2025
rivos-eblot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#205.