ot_usbdev: fix assertion failure
#292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the bus is powered but the device never connects, the link state will be `Disconnected` which triggers an assertion when the bus is powered off. Signed-off-by: Amaury Pouly <amaury.pouly@lowrisc.org>
pamaury
changed the title
ot_usbdev: fix assertion failure
pamaury
requested review from
AlexJones0 and
rivos-eblot
and removed request for
rivos-eblot
AlexJones0
approved these changes
Nov 13, 2025
There was a problem hiding this comment.
Thanks for looking into this @pamaury, this should address the assertion failures that we're seeing in tests at the moment.
rivos-eblot
approved these changes
Nov 14, 2025
Author
|
The CI failures are not related to USB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the bus is powered but the device never connects, the link state will be
Disconnectedwhich triggers an assertion when the bus is powered off.This was not caugh in CI because the QEMU side was merged before the otlib minihost was merged, and the minihost was presumably merged before a QEMU release was made.