Skip to content

Fix SPI device and update Python tools #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Dec 19, 2024
Merged

Fix SPI device and update Python tools #91

merged 12 commits into from
Dec 19, 2024

Conversation

rivos-eblot
Copy link

No description provided.

@rivos-eblot
[ot] scripts/opentitan: pyot.py: add support for virtual test definit…
58b43ad 
…ions

Virtual tests may be used to define multiple tests using the same binary
with different execution options/settings

Signed-off-by: Emmanuel Blot <eblot@rivosinc.com>
@rivos-eblot
[ot] scripts/opentitan: pyot.py: enable same app to run every hart
000f617 
Signed-off-by: Emmanuel Blot <eblot@rivosinc.com>
@rivos-eblot
[ot] python/qemu: ot.lc_ctrl.lcdmi: add an observer to expose the DTM
fe5331c 
Signed-off-by: Emmanuel Blot <eblot@rivosinc.com>
@rivos-eblot
[ot] python/qemu: ot.devproxy: shorten binary debug log messages
71b2955 
Signed-off-by: Emmanuel Blot <eblot@rivosinc.com>
@rivos-eblot
[ot] hw/opentitan: ot_spi_device: remove a left over debug trace
85358f8 
Signed-off-by: Emmanuel Blot <eblot@rivosinc.com>
@rivos-eblot
[ot] hw/jtag: tap_ctrl_rbb: rename variable to be more coherent with …
0111ddb 
…other files

Signed-off-by: Emmanuel Blot <eblot@rivosinc.com>
@rivos-eblot
[ot] hw/opentitan: ot_spi_device: fix indentation of register fields
10c2cac 
Signed-off-by: Emmanuel Blot <eblot@rivosinc.com>
@rivos-eblot
[ot] hw/opentitan: ot_spi_device: fix upload command FIFO status.
dd781da 
Interrupt state for upload command FIFO should not be set if no new
command has been pushed, even if the CMD FIFO is not empty.

Signed-off-by: Emmanuel Blot <eblot@rivosinc.com>
@rivos-eblot
[ot] python/qemu: ot.spi.spi_device: change the read_jedec_id API
520f791 
return a tuple with the page along with the JEDEC ID code.

Signed-off-by: Emmanuel Blot <eblot@rivosinc.com>
@rivos-eblot
[ot] python/qemu: ot.spi.spi_device: add support for multi-chunk reads
b8aae39 
Signed-off-by: Emmanuel Blot <eblot@rivosinc.com>
@rivos-eblot
[ot] scripts/opentitan: otptool.py: add an option to reset specific f…
e25e6da 
…ields

Signed-off-by: Emmanuel Blot <eblot@rivosinc.com>
@rivos-eblot
[ot] scripts/opentitan: otptool.py: add a partition filter option
bca5161 
- add a new option to select which partition(s) and fields(s) to show
  when decoding an OTP image file
- add a new option to hide the OTP image file version

Signed-off-by: Emmanuel Blot <eblot@rivosinc.com>
@rivos-eblot rivos-eblot changed the title Fix SPI device and update Pytnon tools Fix SPI device and update Python tools Dec 17, 2024
@rivos-eblot
Copy link
Author

rivos-eblot commented Dec 17, 2024 •
edited
Loading

@jwnrt I think dd781da applies to your branch as well. Without this fix, there may be a interrupt raised for CMD FIFO not empty and no command in the FIFO :)

@jwnrt
Copy link

jwnrt commented Dec 17, 2024

Thanks, that does look relevant. @AlexJones0, I'm going to be on vacation starting in 30 minutes, would you mind cherry picking this? :)

@rivos-eblot
Copy link
Author

I'm going to be on vacation starting in 30 minutes

Enjoy!

@AlexJones0
Copy link

Thanks, that does look relevant. @AlexJones0, I'm going to be on vacation starting in 30 minutes, would you mind cherry picking this? :)

Sure, I'll open a separate PR cherry-picking that commit across.

@AlexJones0 AlexJones0 mentioned this pull request Dec 18, 2024
Merged
loiclefort
loiclefort approved these changes Dec 19, 2024
View reviewed changes
Copy link

@loiclefort loiclefort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (reviewed internally)

@rivos-eblot rivos-eblot merged commit 5ddfffb into lowRISC:ot-darjeeling-9.1.0 Dec 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loiclefort loiclefort loiclefort approved these changes

@jwnrt jwnrt Awaiting requested review from jwnrt

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rivos-eblot @jwnrt @AlexJones0 @loiclefort