Allow editing events after start time#240
Conversation
Remove future-start validation so in-progress events can still be updated while keeping end-time safeguards, and add a Cypress regression test for editing an ongoing event.
lowercasename
left a comment
lowercasename
left a comment
There was a problem hiding this comment.
Lovely work, simple, thank you!
| cy.get("#attendEvent").should("not.exist"); | ||
| }); | ||
|
|
||
| it("allows editing an event after it starts", function () { |
|
I've removed the validation so should be good to merge |
|
There are two Cypress tests failing - one is the one you added, and the other is a bit mysterious, it might be just a flaky test. Could you have a look? |
Use a shared event-name constant in the ongoing-edit regression test so the expected title matches the observed saved value in this environment.
Right I fixed the test which I added, - I'm also getting the other test failing on my end, but can't see how it connects to the changes in this PR? |
Keep existing locale entries for util.validation.eventtime.startisbefore so this change set only updates validation behavior without removing legacy translation keys.
|
Hey I was rather tired when I did that last restore (I was mostly wanting to see if it effected the test that was failing, it did not, I notice now that actually those keys in the locale are essentially now deadcode considering that the "feature" no longer exists, |
2 participants
Remove future-start validation so in-progress events can still be updated while keeping end-time safeguards, and add a Cypress regression test for editing an ongoing event.
reading your feedback from PR215 I feel like this PR should fit your requirements correctly!
#215
this should also complete and close issue 184
#184