Conversation
Hermit managed go, pre-commit, and shellcheck via ~/bin and .dotfiles/bin/ symlinks. The ~/bin PATH entry was causing conflicts with mise path ordering. Removed: - hermit/ directory and install script - .hermit/ go package config - All hermit-managed bin/ symlinks and scripts - HERMIT_ENV PATH guard in zsh/main.zsh - ~/bin from PATH - Hermit prompt indicators (starship + geometry plugin) - VS Code terminal hermit env var overrides - .hermit/ from global gitignore - bin/ exclusions from pre-commit config Amp-Thread-ID: https://ampcode.com/threads/T-019c53ca-b47d-722b-8df0-e61924de9301
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: caba8c29f7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| fi | ||
| # remove duplicate entries from $PATH | ||
| typeset -U PATH path | ||
| path=("$DOTFILES/bin" "$HOME/.local/bin" $path "/opt/homebrew/sbin" "/opt/homebrew/bin" "$HOME/.cargo/bin") |
There was a problem hiding this comment.
$HOME/bin on PATH for fasd install location
This change drops $HOME/bin from PATH, but zsh/install.sh still installs fasd with PREFIX=$HOME, which places the binary in $HOME/bin; zsh/fasd.zsh then expects fasd to be callable during shell startup. On a fresh setup following this repo’s installer, fasd will no longer be found (and startup may emit command not found) unless users manually adjust PATH or install fasd somewhere else.
Useful? React with 👍 / 👎.
1 participant
Hermit managed go, pre-commit, and shellcheck via
~/binand.dotfiles/bin/symlinks. The~/binPATH entry was causing conflicts with mise path ordering.Removed
hermit/directory and install script.hermit/go package configbin/symlinks and scripts (go,gofmt,pre-commit,shellcheck)HERMIT_ENVPATH guard inzsh/main.zsh~/binfrom PATH.hermit/from global gitignorebin/exclusions from pre-commit configFollow-up
Install
go,pre-commit, andshellcheckvia mise or brew.