feat: accept URL, name, or ID for all page commands#7
Merged
Conversation
All page commands now consistently accept any of: - Notion URL (https://notion.so/...) - Page ID (UUID with or without hyphens) - Page name (exact match, errors on ambiguity) Extracted page reference resolution into internal/cli/resolve.go with: - ParsePageRef: classifies input as URL, ID, or name - ResolvePageID: resolves any reference to a page ID - Robust UUID extraction (32 hex digits, normalised to 8-4-4-4-12) - Ambiguous name detection with candidate listing Removed old looksLikeID and resolvePageByName from cmd/page.go. Amp-Thread-ID: https://ampcode.com/threads/T-019c4484-b1d8-7284-b9e7-66f9b5939872
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6723392b9b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Check URL prefix before extracting UUID, so page names containing 32-char hex substrings are not misclassified as IDs - Apply De Morgan's law in isAllHex (staticcheck QF1001) - Use tagged switch in page edit (staticcheck QF1003) Amp-Thread-ID: https://ampcode.com/threads/T-019c4484-b1d8-7284-b9e7-66f9b5939872
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All page commands now consistently accept any of:
https://notion.so/...)Changes
internal/cli/resolve.go:ParsePageRefclassifies input,ResolvePageIDresolves to a page IDpage view/page edit: now accept names (URLs/IDs passed through to MCP server as before)page create --parent: now accepts URL or name (previously ID-only)page upload --parent: now accepts URL (previously name/ID only)Testing
Tests cover
ParsePageRef,LooksLikeID, andextractNotionUUIDwith URLs, IDs, names, and edge cases.