Skip to content

Restricts the size of format/fourcc byte-sequences to 4 using [u8; 4] instead of len() runtime check#14

Merged
loyd merged 2 commits intoloyd:masterfrom
joelgallant:fourcc-size
Jan 18, 2020
Merged

Restricts the size of format/fourcc byte-sequences to 4 using [u8; 4] instead of len() runtime check#14
loyd merged 2 commits intoloyd:masterfrom
joelgallant:fourcc-size

Conversation

@joelgallant
Copy link
Contributor

No description provided.

@loyd
Copy link
Owner

loyd commented Sep 29, 2018

I chose &[u8] instead of &[u8; 4] becase it was impossible to pass literals like b"ABCD" to a function that accepts &[u8; 4].

Now it's possible.

Can you rebase your commit?

@joelgallant
Copy link
Contributor Author

Does this technically constitute a semver version bump?

@loyd
Copy link
Owner

loyd commented Jan 18, 2020

Thanks for your contribution.
It's been over a year =/.

It's breaking change, so it will be included in 0.6.0.

@loyd loyd merged commit 7e7174b into loyd:master Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants