fix(global list): drop stale "once M3 lands" hint#28
Merged
Conversation
…ng command `lpm global list` against an empty manifest emitted "Try `lpm install -g <pkg>` once M3 lands." That's wrong on two counts: `lpm install -g` ships today, and "M3" is an internal milestone identifier the user has no context for. The pre-existing user-visible-strings sweep caught every "Phase X.Y" mention but missed this "M3" leak by virtue of grepping on the wrong term. Replace with stable wording that points at the real working command and names the manifest path for users who want it for debugging. Verified empirically: `lpm global list` against an empty `$HOME` now prints "Run `lpm install -g <pkg>` to install one. Manifest lives at …/.lpm/global/manifest.toml." Other "M[0-9]" mentions in the codebase are internal `//` / `///` comments only, no other user-visible runtime string is affected. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lpm global listagainst an empty manifest still emitted:Two problems:
lpm install -g <pkg>actually ships today (we just landed--allow-newrejection on the global path in Phase 64 follow-ups: phase-language sweep + migrate fixes + behavioral tag catalog #27). The "once M3 lands" wording tells users a working command isn't available.M3is an internal milestone identifier with no user-facing meaning, exactly the leak class the Phase 64 user-visible-strings sweep was meant to remove. It snuck through that sweep because the grep was scoped toPhase X.Yand missedM[0-9].Replaces the line with stable wording that points at the real command and names the manifest path for users who want it for debugging:
Test plan
HOME=/tmp/empty lpm-rs global listand saw the new message render.cargo clippy --workspace --all-targets -- -D warningscleancargo fmt --checkcleancargo nextest run --workspace --exclude lpm-integration-tests— 5609 pass / 7 skippedcrates/andtests/)M[0-9]mentions in the codebase are internal comments only, no other runtime string affected🤖 Generated with Claude Code