Reject combined forced usage#2155
Merged
Merged
Conversation
Reject combined usage early (exit with clear message).
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds validation to reject the combined usage of the mutually exclusive command-line options --force and --force-no. The implementation exits early with a clear error message when both flags are provided together, preventing conflicting behavior where the application would try to automatically answer "yes" and "no" to prompts simultaneously.
Changes:
- Added early validation in main() to detect and reject combined
--forceand--force-nousage - Added test coverage for the mutually exclusive flags validation
- Updated test setUp/tearDown to properly initialize and reset the FORCE_NO flag
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/mackup/main.py | Added validation check to exit early when both --force and --force-no flags are provided |
| tests/test_cli.py | Added test case for mutually exclusive flags validation and updated setUp/tearDown to initialize/reset FORCE_NO flag |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject combined usage early (exit with clear message).