Ruby 3 #68
Merged
Ruby 3 #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not ruby 3 compatible at all so we'll have to do something else.
Ran `bundle exec github-pages versions --gemfile` to get this, should help us unpin from using github-pages directly.
We filtered out a bunch of explicit versions of jekyll plugins that were blocking the upgrade, but also, got rid if we weren't using them.
Why? Just to tell if what's served is fresh or not.
Because why not? Can't hurt.
Now we're not using the github-pages gem we have to do this "manually". There's advice in https://jekyllrb.com/docs/continuous-integration/github-actions/ on how to do it, and this is the actions file we'd get if we followed those "click about int he UI" instructions.
Apparently bundler puts specific platforms in gemfiles now? Almost certainly we didn't want this, but I'll work it out later. This was prompted by the first attempt to build the site via actions failing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to #67 we realised we needed to get onto ruby 3 and that required getting off the
github-pagesgem and doing stuff ourselves.