Skip to content

Conversation

@seagyn
Copy link
Contributor

@seagyn seagyn commented Dec 9, 2025

Right now, the docker push isn't running. However, if the docker push fails we will have a release but no image. So creating a flow where there can only be a release if there is an image.

@jgericke
Copy link

jgericke commented Dec 9, 2025

I think this is a fine fix,

Can look at adding a workflow dependency between image build/push and release steps with workflow_run down the line:

name: Release
on:
workflow_run:
workflows: ["Run Tests"]
branches: [main]
types:
- completed

jobs:
on-success:
runs-on: ubuntu-latest
if: ${{ github.event.workflow_run.conclusion == 'success' }}
steps:
- run: echo 'The Run Tests workflow passed'

jgericke
jgericke previously approved these changes Dec 9, 2025
@seagyn seagyn merged commit 86837c8 into main Dec 10, 2025
9 checks passed
@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants