Skip to content

[pull] master from tensorflow:master#596

Merged
pull[bot] merged 20 commits intolskov:masterfrom
tensorflow:master
Aug 8, 2025
Merged

[pull] master from tensorflow:master#596
pull[bot] merged 20 commits intolskov:masterfrom
tensorflow:master

Conversation

@pull
Copy link
Copy Markdown

@pull pull bot commented Aug 8, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.3)

Can you help keep this open source service alive? 💖 Please sponsor : )

WillFroom and others added 20 commits August 8, 2025 06:54
PiperOrigin-RevId: 792606193
Clang does not have an i64 suffix

PiperOrigin-RevId: 792607613
This was only needed for Horizontal fusion, which we have removed recently.

PiperOrigin-RevId: 792612383
The original `mkl_deps()` macro can't be used in a select statement because it also has a select statement inside. (Bazel doesn't support nested selects.)

Users should depend on this new `cc_library` target instead.

PiperOrigin-RevId: 792617157
Changing s32 to elementwise -> reduce can make it faster when run through
Triton emitter. We also selectively rewrite s32 reduces coming from this to
make them go through the triton emitter.

PiperOrigin-RevId: 792623194
PiperOrigin-RevId: 792630022
Imported from GitHub PR openxla/xla#29511

Adds end-to-end tests for the SPMD partitioning of dots.
Copybara import of the project:

--
b0dd04bbbca06a2c4714312a2492da5df5e8b8d3 by Philipp Hack <phack@nvidia.com>:

End-to-end tests for SPMD dot partitioning.

--
45c81aa817c85622fc79f2808cea635256e563a2 by Philipp Hack <phack@nvidia.com>:

End-to-end tests for SPMD dot partitioning.

--
98dd09c2107f92d79f5346ccde4d0b5149996126 by Philipp Hack <phack@nvidia.com>:

End-to-end tests for SPMD dot partitioning.

--
c2b5d2924854717052a2011a8ff22cc534e7e5ab by Philipp Hack <phack@nvidia.com>:

End-to-end tests for SPMD dot partitioning.

Merging this change closes #29511

PiperOrigin-RevId: 792637847
PiperOrigin-RevId: 792653688
PiperOrigin-RevId: 792684853
Mingw's builtin header defines a function name which is used in xla, and causes an error. We undefined the macro here.

Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
external/xla/xla/pjrt/gpu/tfrt/tfrt_gpu_client.cc:887:58: error: no member named 'CreateEventW' in 'stream_executor::StreamExecutor'; did you mean 'CreateEvent'?
  887 |     TF_ASSIGN_OR_RETURN(auto se_event, stream->parent()->CreateEvent());
      |                                                          ^~~~~~~~~~~
      |                                                          CreateEvent
/opt/x86_64-w64-mingw32/x86_64-w64-mingw32/sys-root/include/synchapi.h:145:21: note: expanded from macro 'CreateEvent'
  145 | #define CreateEvent __MINGW_NAME_AW(CreateEvent)
      |                     ^

PiperOrigin-RevId: 792697955
The failing test was introduced by:
openxla/xla#29270

A fix is coming soon:
openxla/xla#29990

PiperOrigin-RevId: 792701274
@pull pull bot locked and limited conversation to collaborators Aug 8, 2025
@pull pull bot added the ⤵️ pull label Aug 8, 2025
@pull pull bot merged commit 53eee3e into lskov:master Aug 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.