udp lookups don't work

[mattiash]

Steps to reproduce:

1. Clone the node-dns repo and do npm install
2. run node example/index.js

Actual result:

Prints [] and then hangs.

Expected result:

An actual result.

If I run tcpdump while running example/index.js, I see a SERVFAIL response from google's DNS server:

$ sudo tcpdump -X host 8.8.8.8
tcpdump: data link type PKTAP
tcpdump: verbose output suppressed, use -v or -vv for full protocol decode
listening on pktap, link-type PKTAP (Apple DLT_PKTAP), capture size 262144 bytes
18:38:18.452157 IP 172.20.10.7.51217 > dns.google.domain: 7873 Type0? google.com. (28)
	0x0000:  c698 80e9 e264 80e6 5014 bf1c 0800 4500  .....d..P.....E.
	0x0010:  0038 5435 0000 4011 6055 ac14 0a07 0808  .8T5..@.`U......
	0x0020:  0808 c811 0035 0024 3fbb 1ec1 0000 0001  .....5.$?.......
	0x0030:  0000 0000 0000 0667 6f6f 676c 6503 636f  .......google.co
	0x0040:  6d00 0000 0001                           m.....
18:38:18.525937 IP dns.google.domain > 172.20.10.7.51217: 7873 ServFail 0/0/0 (28)
	0x0000:  80e6 5014 bf1c c698 80e9 e264 0800 4580  ..P........d..E.
	0x0010:  0038 efdc 0000 7811 8c2d 0808 0808 ac14  .8....x..-......
	0x0020:  0a07 0035 c811 0024 bf38 1ec1 8082 0001  ...5...$.8......
	0x0030:  0000 0000 0000 0667 6f6f 676c 6503 636f  .......google.co
	0x0040:  6d00 0000 0001                           m.....
^C
2 packets captured
7 packets received by filter
0 packets dropped by kernel

The other script in example/ work as expected.

[mattiash]

The following patch restores the behaviour from before the commit "add DoH, DNS over TCP and Google Public DNS Client". But I had to change resolve() to resolveA() in example/index.js and I don't really understand why resolve() (i.e. an ANY request) does not work.

diff --git a/example/index.js b/example/index.js
index bd48590..e35e518 100644
--- a/example/index.js
+++ b/example/index.js
@@ -3,6 +3,6 @@ const DNS = require('..');
 const dns = new DNS();

 (async () => {
-  const result = await dns.resolve('google.com');
+  const result = await dns.resolveA('google.com');
   console.log(result.answers);
 })();
\ No newline at end of file
diff --git a/index.js b/index.js
index dbef5b8..63f9e9a 100644
--- a/index.js
+++ b/index.js
@@ -47,7 +47,7 @@ class DNS extends EventEmitter {
    * @param {*} cls
    */
   resolve(domain, type = 'ANY', cls = DNS.Packet.CLASS.IN) {
-    return this.query(domain, DNS.Packet.TYPE[type], cls);
+    return this.query(domain, type, cls);
   }
   resolveA(domain) {
     return this.resolve(domain, 'A');