Skip to content

fixed crash of out-of-bounds Buffer() access with malformed requests: #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lsongdev merged 1 commit into from
May 25, 2026
Merged

fixed crash of out-of-bounds Buffer() access with malformed requests: #102

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packet.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,12 @@
Packet.parse = function(buffer) {
const packet = new Packet();
const reader = new Packet.Reader(buffer);
packet.header = Packet.Header.parse(reader);
try {
packet.header = Packet.Header.parse(reader);
} catch(e){

Check failure on line 153 in packet.js

View workflow job for this annotation

GitHub Actions / build 

Missing space before opening brace

Check failure on line 153 in packet.js

View workflow job for this annotation

GitHub Actions / build 

Expected space(s) after "catch"
debug('node-dns > parse %s error', 'parse', e.message);
return packet;

Check failure on line 155 in packet.js

View workflow job for this annotation

GitHub Actions / build 

Trailing spaces not allowed
}
([ // props parser count
[ 'questions', Packet.Question, packet.header.qdcount ],
[ 'answers', Packet.Resource, packet.header.ancount ],
Expand Down
Loading