Add warning on abstract building subclasses#720
Merged
Conversation
parejkoj
force-pushed
the
u/parejkoj/abstract-builtin
branch
from
a3f517f to
82f1314
Compare
andy-slac
approved these changes
May 31, 2025
andy-slac
left a comment
andy-slac
left a comment
There was a problem hiding this comment.
Looks good, one note is that warning appears in "super() and Multiple Inheritance" section, though it's not quite related to those things. Maybe make it a separate section with a title like "Abstract subclasses of builtin classes"?
parejkoj
force-pushed
the
u/parejkoj/abstract-builtin
branch
from
82f1314 to
e7d826b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Worth adding a note to the dev guide on this after what I learned on DM-50559.