DM-41713: Many calibs (bias/flat/dark) preloaded in LATISS testing #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfindeisen
force-pushed
the
tickets/DM-41713
branch
2 times, most recently
from
a274af0 to
93ace76
Compare
TallJimbo
approved these changes
Dec 15, 2023
queryDatasetAssociations is extremely slow (the loop over dataset types takes a minute to complete), so its use makes filtering a bottleneck. Use find_dataset instead to select by timestamp. We cannot yet use find_dataset to search for calibs directly, because it can only be run on one dataset type at a time and we don't yet have the sophistication to organically determine which types the pipelines need.
The unfiltered calibs has many sets of calibs with the same type and data ID, but different run and validity range. Calls to find_dataset on each such calib return the same result. Do the filtering locally so that we call find_dataset only once per each filtered calib.
kfindeisen
force-pushed
the
tickets/DM-41713
branch
from
93ace76 to
4d1d688
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces our first call to
queryDatasetAssociationswith a much faster loop over individual datasets. We still need the second call toqueryDatasetAssociations, which provides the information we need to recertify the calibs we've preloaded (see DM-41915), but that call will be skipped if calib preload becomes a no-op.