DM-50500: Prompt Processing uses incorrect definition of SingleFrame
#302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pipelines included analyzeCalibrationMetrics (unknown label?) but did not include associateSolarSystemDirectSource. Making the pipeline definition opt-out instead of opt-in should keep it closer to its intended meaning of "ap_pipe/SingleFrame, without Preprocessing".
SingleFrame.yaml has tasks not found in ApPipe.yaml, so it must be updated separately.
isullivan
approved these changes
Apr 25, 2025
| # Run in prep_butler or Preprocessing.yaml | ||
| - getRegionTimeFromVisit | ||
| - mpSkyEphemerisQuery | ||
| - loadDiaCatalogs |
There was a problem hiding this comment.
It is true we don't want to run loadDiaCatalogs in SingleFrame, but I don't actually see that in the imports so I think the exclusion is unnecessary.
There was a problem hiding this comment.
Yes, it's not there. This was intended as "future-proofing" against changes to SingleFrame (which I think is part of what caused this mess in the first place). We want to include any changes to upstream SingleFrame, except changes that incorporate more of preprocessing.
And of course I tested that excluding a nonexistent task is legal. 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects the definition of our
SingleFramepipelines to be more aligned withap_pipe's.