-
Notifications
You must be signed in to change notification settings - Fork 0
DM-50500: Prompt Processing uses incorrect definition of SingleFrame
#302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,12 @@ | ||
| description: >- | ||
| Single-frame pipeline for the case in which | ||
| no templates exist, specialized for HSC | ||
| Unlike ap_pipe/SingleFrame.yaml, this pipeline is not standalone. | ||
| imports: | ||
| - location: $AP_PIPE_DIR/pipelines/HSC/SingleFrame.yaml | ||
| include: | ||
| - apPipeSingleFrame | ||
| - analyzeCalibrationMetrics | ||
| exclude: | ||
| # Run in prep_butler or Preprocessing.yaml | ||
| - getRegionTimeFromVisit | ||
| - mpSkyEphemerisQuery | ||
| - loadDiaCatalogs | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,12 @@ | ||
| description: >- | ||
| Single-frame pipeline for the case in which | ||
| no templates exist, specialized for LATISS | ||
| Unlike ap_pipe/SingleFrame.yaml, this pipeline is not standalone. | ||
|
|
||
| imports: | ||
| - location: $AP_PIPE_DIR/pipelines/LATISS/SingleFrame.yaml | ||
| include: | ||
| - apPipeSingleFrame | ||
| - analyzeCalibrationMetrics | ||
| exclude: | ||
| # Run in prep_butler or Preprocessing.yaml | ||
| - getRegionTimeFromVisit | ||
| - mpSkyEphemerisQuery | ||
| - loadDiaCatalogs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,12 @@ | ||
| description: >- | ||
| Single-frame pipeline for the case in which | ||
| no templates exist, specialized for LSSTCam-imSim | ||
| Unlike ap_pipe/SingleFrame.yaml, this pipeline is not standalone. | ||
|
|
||
| imports: | ||
| - location: $AP_PIPE_DIR/pipelines/LSSTCam-imSim/SingleFrame.yaml | ||
| include: | ||
| - apPipeSingleFrame | ||
| - analyzeCalibrationMetrics | ||
| exclude: | ||
| # Run in prep_butler or Preprocessing.yaml | ||
| - getRegionTimeFromVisit | ||
| - mpSkyEphemerisQuery | ||
| - loadDiaCatalogs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,12 @@ | ||
| description: >- | ||
| Single-frame pipeline for the case in which | ||
| no templates exist, specialized for LSSTCam | ||
| Unlike ap_pipe/SingleFrame.yaml, this pipeline is not standalone. | ||
|
|
||
| imports: | ||
| - location: $AP_PIPE_DIR/pipelines/LSSTCam/SingleFrame.yaml | ||
| include: | ||
| - apPipeSingleFrame | ||
| - analyzeCalibrationMetrics | ||
| exclude: | ||
| # Run in prep_butler or Preprocessing.yaml | ||
| - getRegionTimeFromVisit | ||
| - mpSkyEphemerisQuery | ||
| - loadDiaCatalogs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,12 @@ | ||
| description: >- | ||
| Single-frame pipeline for the case in which | ||
| no templates exist, specialized for LSSTComCam | ||
| Unlike ap_pipe/SingleFrame.yaml, this pipeline is not standalone. | ||
|
|
||
| imports: | ||
| - location: $AP_PIPE_DIR/pipelines/LSSTComCam/SingleFrame.yaml | ||
| include: | ||
| - apPipeSingleFrame | ||
| - analyzeCalibrationMetrics | ||
| exclude: | ||
| # Run in prep_butler or Preprocessing.yaml | ||
| - getRegionTimeFromVisit | ||
| - mpSkyEphemerisQuery | ||
| - loadDiaCatalogs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,12 @@ | ||
| description: >- | ||
| Single-frame pipeline for the case in which | ||
| no templates exist, specialized for LSSTComCamSim | ||
| Unlike ap_pipe/SingleFrame.yaml, this pipeline is not standalone. | ||
|
|
||
| imports: | ||
| - location: $AP_PIPE_DIR/pipelines/LSSTComCamSim/SingleFrame.yaml | ||
| include: | ||
| - apPipeSingleFrame | ||
| - analyzeCalibrationMetrics | ||
| exclude: | ||
| # Run in prep_butler or Preprocessing.yaml | ||
| - getRegionTimeFromVisit | ||
| - mpSkyEphemerisQuery | ||
| - loadDiaCatalogs |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is true we don't want to run
loadDiaCatalogsin SingleFrame, but I don't actually see that in the imports so I think the exclusion is unnecessary.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's not there. This was intended as "future-proofing" against changes to
SingleFrame(which I think is part of what caused this mess in the first place). We want to include any changes to upstreamSingleFrame, except changes that incorporate more of preprocessing.And of course I tested that excluding a nonexistent task is legal. 🙂