Skip to content

Conversation

ktlim
Copy link
Contributor

@ktlim ktlim commented May 4, 2023

No description provided.

ARG CALIB_REPO
ARG IMAGE_BUCKET
ARG IMAGE_TIMEOUT
ARG BUCKET_TOPIC
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not about this PR, but this makes me wonder why some env vars in activator aren't here and it works just fine...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the Dockerfile reference, I think these are actually not that useful because we don't really want them to be container-build-time arguments; we want them to be deploy-time variables. So they're really only serving as a kind of (misleading) documentation.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably should remove them then. I can create a ticket for that.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ktlim ktlim force-pushed the tickets/DM-38596 branch from e39dfdf to e9520bd Compare May 4, 2023 13:10
@ktlim ktlim merged commit 8d25a35 into main May 4, 2023
@ktlim ktlim deleted the tickets/DM-38596 branch May 4, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants