DM-38596: Get bucket_topic from env var. #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsinfang
reviewed
May 4, 2023
| ARG CALIB_REPO | ||
| ARG IMAGE_BUCKET | ||
| ARG IMAGE_TIMEOUT | ||
| ARG BUCKET_TOPIC |
There was a problem hiding this comment.
Not about this PR, but this makes me wonder why some env vars in activator aren't here and it works just fine...
There was a problem hiding this comment.
Looking at the Dockerfile reference, I think these are actually not that useful because we don't really want them to be container-build-time arguments; we want them to be deploy-time variables. So they're really only serving as a kind of (misleading) documentation.
There was a problem hiding this comment.
We probably should remove them then. I can create a ticket for that.
hsinfang
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.