Skip to content

DM-38596: Get bucket_topic from env var. #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2023
Merged

DM-38596: Get bucket_topic from env var. #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Dockerfile.activator
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ ARG PORT
ARG CALIB_REPO
ARG IMAGE_BUCKET
ARG IMAGE_TIMEOUT
ARG BUCKET_TOPIC
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not about this PR, but this makes me wonder why some env vars in activator aren't here and it works just fine...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the Dockerfile reference, I think these are actually not that useful because we don't really want them to be container-build-time arguments; we want them to be deploy-time variables. So they're really only serving as a kind of (misleading) documentation.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably should remove them then. I can create a ticket for that.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DM-39030

WORKDIR $APP_HOME
COPY python/activator activator/
COPY pipelines pipelines/
Expand Down
3 changes: 1 addition & 2 deletions python/activator/activator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,7 @@
# Kafka group; must be worker-unique to keep workers from "stealing" messages for others.
kafka_group_id = str(uuid.uuid4())
# The topic on which to listen to updates to image_bucket
# bucket_topic = f"{instrument_name}-image"
bucket_topic = "rubin-prompt-processing"
bucket_topic = os.environ.get("BUCKET_TOPIC", "rubin-prompt-processing")

setup_usdf_logger(
labels={"instrument": instrument_name},
Expand Down