DM-39678: Allow Prompt Prototype to be configured with no pipeline #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code now tests for an applicable pipeline as soon as it parses the next_visit message. If there is no pipeline, this is treated as a semantic error by the client (i.e., the fanout service).
This change makes it possible to program the Prompt Processing service to ignore visits that we either can't or don't want to process.
The time zone used to datestamp runs was changed in #68, but the tests were never updated to match. This caused failures when running the tests between 0:00 and 12:00 UTC.
The survey is generally more human-readable than the group ID. Since commissioning runs mix different kinds of observations (represented as different surveys), it's a valuable piece of context for understanding what kind of visit is being processed.
dspeck1
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some logic that lets us skip Prompt Processing execution for specific types of visits. This is mainly intended for spectroscopic observations taken with LATISS.